Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize into descriptive folders #31

Merged
merged 3 commits into from
Apr 3, 2025
Merged

Reorganize into descriptive folders #31

merged 3 commits into from
Apr 3, 2025

Conversation

maxrjones
Copy link
Member

Moves all the pipelines into organized folders. Also removes the bash scripts since we couldn't properly clear the cache on the HPC so the results may not be accurate.

@maxrjones maxrjones requested review from negin513 and weiji14 April 2, 2025 19:36
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you have time, maybe update the title in DALI_e2e/README.md like this:

- # How to run!
+ # DALI pipeline end-to-end example
+
+ ## How to run!

so that it's clearer what "e2e" means. Could also make a DALI_basic/README.md file to mention the differences between DALI_ERA5.py and DALI_images.py.

@negin513
Copy link
Contributor

negin513 commented Apr 2, 2025

I'd suggest the following names:

  1. DALI_basic --> DALI_Zarr_basic
  2. DALI_e2e --> ML_Example or ML_Optimization
  3. benchmark ? @weiji14, something along the lines of additional benchmarks?

@maxrjones maxrjones merged commit 0d61545 into main Apr 3, 2025
@maxrjones maxrjones deleted the reorg branch April 3, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants