Skip to content

Change BinderPR action to generate Binder link on /binder comment#631

Merged
weiji14 merged 1 commit into
masterfrom
actionfix/binder
Dec 9, 2025
Merged

Change BinderPR action to generate Binder link on /binder comment#631
weiji14 merged 1 commit into
masterfrom
actionfix/binder

Conversation

@weiji14
Copy link
Copy Markdown
Member

@weiji14 weiji14 commented Dec 8, 2025

Only create the Binder button when requested in a comment with /binder.

Trigger is changed from on: pull_request_target (which can be dangerous, see https://docs.zizmor.sh/audits/#dangerous-triggers) to on: issue_comment.

Reference:

@weiji14 weiji14 marked this pull request as ready for review December 8, 2025 23:40
@weiji14 weiji14 requested a review from scottyhq December 8, 2025 23:40
@scottyhq
Copy link
Copy Markdown
Member

scottyhq commented Dec 9, 2025

I think just getting rid of the binder badge workflow altogether would be fine ;)

Copy link
Copy Markdown
Member

@scottyhq scottyhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge if you'd like!

@weiji14
Copy link
Copy Markdown
Member Author

weiji14 commented Dec 9, 2025

I'll merge for now (at least it'll fix the BinderPR status check), and we can decide to remove the workflow altogether next year if it's not used much.

@weiji14 weiji14 merged commit 5a40e8d into master Dec 9, 2025
5 of 6 checks passed
@weiji14 weiji14 deleted the actionfix/binder branch December 9, 2025 03:12
@weiji14 weiji14 mentioned this pull request Apr 22, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants