-
Notifications
You must be signed in to change notification settings - Fork 195
DEVX-3831: Create new Dockerfile to run Terminus in isolated environment #2735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
erikwebb
wants to merge
5
commits into
pantheon-systems:4.x
Choose a base branch
from
erikwebb:erikwebb/terminus-Dockerfile
base: 4.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
881d4d9
Create new Dockerfile to run Terminus in isolated environment
erikwebb 9d65f83
Test Docker build and run on all changes
erikwebb 3394560
Do not run Terminus container as root user
erikwebb 1f966dd
Use PHP 8.3 Alpine images for both build and run
erikwebb ce4b1d4
Update to PHP 8.4 and latest Box release
erikwebb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # --- Composer Layer --- | ||
| FROM composer:2 AS composer | ||
|
|
||
| # --- Build Layer --- | ||
| FROM php:8.4-cli-alpine AS build | ||
|
|
||
| # Install dependencies for building PHAR | ||
| RUN apk add --no-cache bash git wget | ||
|
|
||
| # Install Composer | ||
| COPY --from=composer /usr/bin/composer /usr/bin/composer | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| # Copy source files | ||
| COPY . . | ||
|
|
||
| # Install PHP dependencies | ||
| RUN composer install --no-interaction --no-dev --optimize-autoloader | ||
|
|
||
| # Install Box for PHAR building | ||
| RUN wget https://github.com/box-project/box/releases/download/4.6.7/box.phar -O /usr/local/bin/box && chmod +x /usr/local/bin/box | ||
|
|
||
| # Build PHAR file | ||
| RUN ./scripts/phar_build.sh | ||
|
|
||
| # --- Runtime Layer --- | ||
| FROM php:8.4-cli-alpine | ||
|
|
||
| # Install Git, Unzip, and Wget dependencies | ||
| RUN apk add --no-cache git openssh | ||
|
|
||
| # Create a non-root user and group | ||
| RUN addgroup -S terminus && adduser -S terminus -G terminus | ||
|
|
||
| # Switch to non-root user | ||
| USER terminus | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| # Copy Composer from build layer | ||
| COPY --from=build /usr/bin/composer /usr/bin/composer | ||
|
|
||
| # Copy built PHAR from build layer | ||
| COPY --from=build /app/terminus.phar /app/terminus.phar | ||
|
|
||
| # Set entrypoint to run the PHAR | ||
| ENTRYPOINT ["/app/terminus.phar"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth holding of on this until we have a public registry we can push to or until this repo has been onboarded to the WIF stuff so we can use the shared actions.