cmake: Do not look for libpthread on Android#287
Open
brunvonlope wants to merge 1 commit intopantoniou:masterfrom
Open
cmake: Do not look for libpthread on Android#287brunvonlope wants to merge 1 commit intopantoniou:masterfrom
brunvonlope wants to merge 1 commit intopantoniou:masterfrom
Conversation
dg0yt
reviewed
May 2, 2026
dg0yt
left a comment
dg0yt
left a comment
There was a problem hiding this comment.
CMake's FindThreads.cmake works very well on Windows and Android. (On Windows, it just doesn't provide POSIX threads.) So it is really possible to keep CMake code simple.
It is provided inside bionic libc.
brunvonlope
force-pushed
the
bruno/android-support
branch
from
7abd498 to
fb4d4e8
Compare
Author
|
@dg0yt I confirmed your minimal fix work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes possible to build libfyaml on Android with vcpkg: microsoft/vcpkg#51490