Replaced 3rd party script with first-party script exposing GH vars #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variables we require - Updated actions to v9 - Formatted with Prettier
sureshjoshi
commented
Jun 13, 2024
There was a problem hiding this comment.
Ensure the diff is "hiding whitespace", otherwise this will be a pain
sureshjoshi
commented
Jun 13, 2024
| core.exportVariable("ACTIONS_CACHE_URL", process.env.ACTIONS_CACHE_URL || ""); | ||
| core.exportVariable("ACTIONS_RUNTIME_TOKEN", process.env.ACTIONS_RUNTIME_TOKEN || ""); | ||
|
|
||
| - uses: pantsbuild/actions/init-pants@v9 |
There was a problem hiding this comment.
Change 2: Bumped version
sureshjoshi
commented
Jun 13, 2024
| with: | ||
| platforms: linux/amd64,linux/arm64 | ||
|
|
||
| - name: Set up environment variables for Pants (Docker) to use GHA Cache |
There was a problem hiding this comment.
Change 1: Replaced crazy-max with GH script
benjyw
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explicitly exposes the two GH
ACTIONenvironment variables we need. This means we pull one less 3rd party dep (in favour of a GH dep), but more importantly, we directly expose the two env vars we needAssuming Pants users will cargo cult this file, I think being a bit more explicit is nice.
Also updated actions to v9, and formatted with Prettier. Ran
actionlintover the code to no complaints.