Demonstrate more javascript backend functionality #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riisi
commented
Mar 9, 2024
| package_json( | ||
| name="hello_pkg", | ||
| scripts=[ | ||
| node_test_script( |
There was a problem hiding this comment.
Side note - node_test_script and node_build_script don't show up in the documentation under the package_json target - is there a way we can make that happen?
There was a problem hiding this comment.
Good question! We have a similar situation with https://www.pantsbuild.org/2.19/reference/targets/python_distribution#provides : it is a target field whose value is created by a call to python_artifact(). In that case it looks like we manually add a link in that field's docs to relevant guide docs.
So I guess we should do that here too.
benjyw
approved these changes
Mar 9, 2024
|
Looks great, thank you so much @riisi, this will come in handy as we add support for TypeScript. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.