backend: add support for TypeScript #20208
Conversation
AlexTereshenkov
changed the title
|
@AlexTereshenkov I see the |
Yes, certainly this is just to ease testing things out for everyone :) not intending to merge it at all, tbh. We'll have tests later. |
|
@AlexTereshenkov I know you're not intending to merge it, but there are other things like this over in |
| for package in import_strings.package_imports: | ||
| if package.startswith("@"): | ||
| # it's a 3rd-party package? | ||
| continue |
There was a problem hiding this comment.
This is not a correct assumption.
| # having `import { foo } from 'bar';` means there may be | ||
| # `src/bar/index.ts` if `bar` is a first-party code package | ||
| for ext in TS_FILE_EXTENSIONS: | ||
| # TODO: the import statements are not providing absolute paths; we have to figure out somehow what address |
There was a problem hiding this comment.
We need special handling of index.ts/js files and what names they point to. We also need to treat the ambiguity problem of naming local top-level folders the same as third party packages the same as TS (I dont recall it offhand but I believe it prefers local over 3rd party?).
I believe tsconfig root directories and index.ts modules have to be slurped into the inference impl to behave correctly.
| return InferredTypeScriptDependencies(addresses) | ||
|
|
||
|
|
||
| @rule("Get dependencies of typescript_test targets.") |
There was a problem hiding this comment.
Surely all of these can be just the one rule?
| addresses = [] | ||
|
|
||
| for path in import_strings.file_imports: | ||
| # check if an import is a directory (that should contain `index.ts` or `index.tsx`) |
There was a problem hiding this comment.
This should be handled similarily to how __init__.py files are treated I believe, and then fed into the rust parser as a pattern via the metadata.
There was a problem hiding this comment.
Meaning a line such as
import * from "myMod"should be inferred as rootDir/myMod/index.ts
because we ahead of time know all index.ts file locations, and have constructed patterns like:
{"myMod": ["./myMod/index.ts"]}| ) | ||
| from pants.util.strutil import help_text | ||
|
|
||
| TS_FILE_EXTENSIONS = (".ts", ".tsx") |
There was a problem hiding this comment.
I doubt we're ready to deal with tsx at this stage? It invites a lot of questions of how we (wont/dont) handle the transpilation of these sources. I understand this is to enable the test goal, in which the runner transpiles stuff on the fly, but I'm fairly sure running the compiler is what comes next? And in that case we'd want special targets for .tsx that it doesnt touch, because it cant parse them.
|
Just want to add that I think its really nice to see things move in this area! |
|
I'll also add that ts files can depend on js, and I'm not sure whether the inference impl here deals with that? |
Work towards #20208 Adding targets for TypeScript sources and tests.
Work towards #20208. Add tailor goal to create `typescript_sources` and `typescript_tests` targets. ``` $ find testprojects/src/ts -name "BUILD" -type f -delete $ pants tailor testprojects/src/ts:: Created testprojects/src/ts/frontend/config/BUILD: - Add typescript_sources target config Created testprojects/src/ts/frontend/deployment/BUILD: - Add typescript_sources target deployment Created testprojects/src/ts/frontend/services/BUILD: - Add typescript_sources target services - Add typescript_tests target tests Created testprojects/src/ts/frontend/utils/BUILD: - Add typescript_sources target utils ```
This is an attempt to convert an internal plugin to a generic support of TypeScript for Pants.
typescript_sourcesandtypescript_testsgenerators with respective single source targets,typescript_sourceandtypescript_test.tailorgoal with a gotcha; see TODOs.Run these commands in the checkout of this branch: