Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Update hadolint version to fix segmentation fault issue #20456

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

riisi
Copy link
Contributor

@riisi riisi commented Jan 24, 2024

While this is a beta, the only change since 2.12 is to remove UPX compression on the binary releases.

The UPX compression is believed to cause segmentation fault issues - see hadolint/hadolint#919, hadolint/hadolint#823, also noted in Pants Slack.

There's no darwin_arm64 binary available, although I can confirm the x86 binary works on my m3 machine.
Although, I'm unable to reproduce the issue on my machine with the original version since doing the testing for this change.

@riisi riisi added backend: Docker Docker backend-related issues category:bugfix Bug fixes for released features labels Jan 24, 2024
@riisi riisi self-assigned this Jan 24, 2024
@riisi riisi requested review from huonw and kaos January 24, 2024 05:20
Copy link
Member

@kaos kaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Seeing that we already use mac x86 also on mac arm, I figure this would likely work equally also for this new version.

@kaos kaos changed the title Update hadolint version to fix segmentation fault issue Docker: Update hadolint version to fix segmentation fault issue Jan 24, 2024
@kaos kaos merged commit 821ed57 into pantsbuild:main Jan 24, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: Docker Docker backend-related issues category:bugfix Bug fixes for released features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants