Docker: Add full_directory interpolation value for repository configuration.
#20530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaos
reviewed
Feb 12, 2024
huonw
reviewed
Feb 13, 2024
kaos
reviewed
Feb 13, 2024
Co-authored-by: Andreas Stenius <[email protected]>
Co-authored-by: Andreas Stenius <[email protected]>
Co-authored-by: Andreas Stenius <[email protected]>
Co-authored-by: Andreas Stenius <[email protected]>
kaos
approved these changes
Feb 14, 2024
Comment on lines
-115
to
+118
| The `name` variable is the `docker_image`'s target name, `directory` and | ||
| `parent_directory` are the name of the directory in which the BUILD file is for the | ||
| target, and its parent directory respectively. | ||
| The `name` variable is the `docker_image`'s target name. | ||
|
|
||
| With the directory variables available, given a sample repository path of `baz/foo/bar/BUILD`, | ||
| then `directory` is `bar`, `parent_directory` is `foo` and `full_directory` will be `baz/foo/bar`. |
kaos
changed the title
full_directory interpolation value for repository configuration.
|
@kaos i do not have the permissions to merge this (nor should I :-) ) so it's in your hands now Thanks |
Yea, I know thanks 😃 Was waiting a beat to give @huonw time to speak up in case he (or anyone else) had any final remarks before landing. Will merge this tomorrow if nothing turns up. 👍🏽 |
huonw
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the BUILD file full path, as a variable to the docker backend configuration.