Remove dict_with_files_option #20982
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huonw
force-pushed
the
huonw/rm-dict-with-files-option
branch
from
b244c58 to
20fdf37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
dict_with_files_optionoption member type function has been unused in this repository since b3a4027 / #10142 ~4 years ago, and before v2. This thus removes this.I was looking at
OptionsFingerprinterand noticed this seems to be unused.Removing is easy enough... but maybe we should deprecate first?
It's hypothetically possible that someone could define an option type with
member_type = dict_with_files_optionin a third-party plugin (and then useOptionsFingerprinterwith their own scope).