Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error message for PATH with relative path #21914

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

kevin-oliveira-zocdoc
Copy link
Contributor

Description

Fix the message for when there are relative paths on PATH.

@kevin-oliveira-zocdoc
Copy link
Contributor Author

This might not need a release note? Could we add the label release-notes:not-required?

@cburroughs cburroughs added the release-notes:not-required PR doesn't require mention in release notes label Feb 4, 2025
@cburroughs
Copy link
Contributor

Thanks! I'm looking at which order I want to cherry-pick some changes and hope to land this soon.

@tdyas tdyas added the category:internal CI, fixes for not-yet-released features, etc. label Feb 5, 2025
@tdyas
Copy link
Contributor

tdyas commented Feb 5, 2025

Thanks! I'm looking at which order I want to cherry-pick some changes and hope to land this soon.

@cburroughs: I'll defer to you then to land the PR.

@cburroughs
Copy link
Contributor

FYI, if you got to this error message you may be interested in #21916

@cburroughs cburroughs added this to the 2.24.x milestone Feb 5, 2025
@cburroughs cburroughs merged commit 8553a76 into pantsbuild:main Feb 5, 2025
24 checks passed
@WorkerPants
Copy link
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

✔️ 2.24.x

Successfully opened #21922.


Thanks again for your contributions!

🤖 Beep Boop here's my run link

cburroughs pushed a commit that referenced this pull request Feb 5, 2025
#21922)

# Description

Fix the message for when there are relative paths on PATH.

Co-authored-by: Kevin Oliveira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc. release-notes:not-required PR doesn't require mention in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants