support debug mode for experimental_test_shell_command target type
#21957
Conversation
|
|
||
| return TestDebugRequest( | ||
| InteractiveProcess.from_process( | ||
| shell_process, forward_signals_to_process=False, restartable=True |
There was a problem hiding this comment.
More of a question about pants test --debug in general: Should restartable be configurable somehow?
There was a problem hiding this comment.
Good question. It's occasionally annoying if I forget that --debug restarts on file change, and so I make a few edits, save, and find my in-progress debugging session interrupted.
I don't know if I'd remember to pass an extra flag like pants test --debug --no-debug-restart or whatever.
There was a problem hiding this comment.
Maybe such a flag should be specific to the kind of test then (and then configured in pants.toml)?
There was a problem hiding this comment.
In any event, going to land this PR since I'm just matching existing behavior of our test --debug impls here.
|
|
||
| return TestDebugRequest( | ||
| InteractiveProcess.from_process( | ||
| shell_process, forward_signals_to_process=False, restartable=True |
There was a problem hiding this comment.
Good question. It's occasionally annoying if I forget that --debug restarts on file change, and so I make a few edits, save, and find my in-progress debugging session interrupted.
I don't know if I'd remember to pass an extra flag like pants test --debug --no-debug-restart or whatever.
Support debug mode for the
experimental_test_shell_commandtarget type so that users can execute the tests in interactive mode.