Allow processes to occupy more than one slot in the execution semaphore #21960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry @chris-smith-zocdoc , I think this slipped below the fold. Looking now. |
benjyw
reviewed
Mar 6, 2025
| Exclusive, | ||
| } | ||
|
|
||
| // TODO Unclear why I need this or when its invoked, compile error for CommandSpec |
There was a problem hiding this comment.
Would be good to figure this out...
benjyw
reviewed
Mar 6, 2025
| let py_type = conc.get_type(); | ||
| let py_name = py_type.name().unwrap(); | ||
| let type_name = py_name.to_str().unwrap(); | ||
| match type_name { |
There was a problem hiding this comment.
Clunky, but I don't see a better way to model a rust enum in Python, so this is fine.
There was a problem hiding this comment.
The current pass at the python api feels clunky to use too though, I could use some perspective there in how we'd want plugin authors to define this (and eventually how it could trickle down into the fields of targets if necessary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21626
Draft for early feedback on the approach.
I was able to manually test that this appears to work from the plugin side, though I plan on adding tests here once the design is agreed upon.
Slack conversation https://pantsbuild.slack.com/archives/C0D7TNJHL/p1738988769732369?thread_ts=1738988769.732369&cid=C0D7TNJHL