Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the release process #21966

Merged
merged 2 commits into from
Feb 18, 2025
Merged

fix the release process #21966

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce4f5fb
fix the release process
tdyas Feb 17, 2025
fefd2c1
better way to set env var in GHA
tdyas Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 68 additions & 44 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,21 @@ jobs:
subject-path: dist/deploy/wheels/pantsbuild.pants/**/pantsbuild.pants-*.whl
- if: needs.release_info.outputs.is-release == 'true'
name: Rename the Pants Pex to its final name for upload
run: 'PEX_FILENAME=pants.$PANTS_VER-$PY_VER-$PLAT.pex
run: 'PANTS_VER=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import
pants.version;print(pants.version.VERSION)")

PY_VER=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import
sys;print(f''cp{sys.version_info[0]}{sys.version_info[1]}'')")

PLAT=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import os;print(f''{os.uname().sysname.lower()}_{os.uname().machine.lower()}'')")

PEX_FILENAME=pants.$PANTS_VER-$PY_VER-$PLAT.pex


mv dist/src.python.pants/pants-pex.pex dist/src.python.pants/$PEX_FILENAME

echo "PEX_FILENAME=$PEX_FILENAME" >> "$GITHUB_ENV"

'
- continue-on-error: true
if: needs.release_info.outputs.is-release == 'true'
Expand All @@ -97,16 +108,11 @@ jobs:
subject-path: dist/src.python.pants/*.pex
- if: needs.release_info.outputs.is-release == 'true'
name: Upload Wheel and Pex
run: "PANTS_VER=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c \"\
import pants.version;print(pants.version.VERSION)\")\nPY_VER=$(PEX_INTERPRETER=1\
\ dist/src.python.pants/pants-pex.pex -c \"import sys;print(f'cp{sys.version_info[0]}{sys.version_info[1]}')\"\
)\nPLAT=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c \"import\
\ os;print(f'{os.uname().sysname.lower()}_{os.uname().machine.lower()}')\"\
)\nPEX_FILENAME=pants.$PANTS_VER-$PY_VER-$PLAT.pex\n\ncurl -L --fail \\\n\
\ -X POST \\\n -H \"Authorization: Bearer ${{ github.token }}\" \\\n\
\ -H \"Content-Type: application/octet-stream\" \\\n ${{ needs.release_info.outputs.release-asset-upload-url\
\ }}?name=$PEX_FILENAME \\\n --data-binary \"@dist/src.python.pants/$PEX_FILENAME\"\
\n\nWHL=$(find dist/deploy/wheels/pantsbuild.pants -type f -name \"pantsbuild.pants-*.whl\"\
run: "curl -L --fail \\\n -X POST \\\n -H \"Authorization: Bearer ${{\
\ github.token }}\" \\\n -H \"Content-Type: application/octet-stream\"\
\ \\\n ${{ needs.release_info.outputs.release-asset-upload-url }}?name=$PEX_FILENAME\
\ \\\n --data-binary \"@dist/src.python.pants/$PEX_FILENAME\"\n\nWHL=$(find\
\ dist/deploy/wheels/pantsbuild.pants -type f -name \"pantsbuild.pants-*.whl\"\
)\ncurl -L --fail \\\n -X POST \\\n -H \"Authorization: Bearer ${{ github.token\
\ }}\" \\\n -H \"Content-Type: application/octet-stream\" \\\n \"${{\
\ needs.release_info.outputs.release-asset-upload-url }}?name=$(basename $WHL)\"\
Expand Down Expand Up @@ -192,10 +198,21 @@ jobs:
subject-path: dist/deploy/wheels/pantsbuild.pants/**/pantsbuild.pants-*.whl
- if: needs.release_info.outputs.is-release == 'true'
name: Rename the Pants Pex to its final name for upload
run: 'PEX_FILENAME=pants.$PANTS_VER-$PY_VER-$PLAT.pex
run: 'PANTS_VER=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import
pants.version;print(pants.version.VERSION)")

PY_VER=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import
sys;print(f''cp{sys.version_info[0]}{sys.version_info[1]}'')")

PLAT=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import os;print(f''{os.uname().sysname.lower()}_{os.uname().machine.lower()}'')")

PEX_FILENAME=pants.$PANTS_VER-$PY_VER-$PLAT.pex


mv dist/src.python.pants/pants-pex.pex dist/src.python.pants/$PEX_FILENAME

echo "PEX_FILENAME=$PEX_FILENAME" >> "$GITHUB_ENV"

'
- continue-on-error: true
if: needs.release_info.outputs.is-release == 'true'
Expand All @@ -205,16 +222,11 @@ jobs:
subject-path: dist/src.python.pants/*.pex
- if: needs.release_info.outputs.is-release == 'true'
name: Upload Wheel and Pex
run: "PANTS_VER=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c \"\
import pants.version;print(pants.version.VERSION)\")\nPY_VER=$(PEX_INTERPRETER=1\
\ dist/src.python.pants/pants-pex.pex -c \"import sys;print(f'cp{sys.version_info[0]}{sys.version_info[1]}')\"\
)\nPLAT=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c \"import\
\ os;print(f'{os.uname().sysname.lower()}_{os.uname().machine.lower()}')\"\
)\nPEX_FILENAME=pants.$PANTS_VER-$PY_VER-$PLAT.pex\n\ncurl -L --fail \\\n\
\ -X POST \\\n -H \"Authorization: Bearer ${{ github.token }}\" \\\n\
\ -H \"Content-Type: application/octet-stream\" \\\n ${{ needs.release_info.outputs.release-asset-upload-url\
\ }}?name=$PEX_FILENAME \\\n --data-binary \"@dist/src.python.pants/$PEX_FILENAME\"\
\n\nWHL=$(find dist/deploy/wheels/pantsbuild.pants -type f -name \"pantsbuild.pants-*.whl\"\
run: "curl -L --fail \\\n -X POST \\\n -H \"Authorization: Bearer ${{\
\ github.token }}\" \\\n -H \"Content-Type: application/octet-stream\"\
\ \\\n ${{ needs.release_info.outputs.release-asset-upload-url }}?name=$PEX_FILENAME\
\ \\\n --data-binary \"@dist/src.python.pants/$PEX_FILENAME\"\n\nWHL=$(find\
\ dist/deploy/wheels/pantsbuild.pants -type f -name \"pantsbuild.pants-*.whl\"\
)\ncurl -L --fail \\\n -X POST \\\n -H \"Authorization: Bearer ${{ github.token\
\ }}\" \\\n -H \"Content-Type: application/octet-stream\" \\\n \"${{\
\ needs.release_info.outputs.release-asset-upload-url }}?name=$(basename $WHL)\"\
Expand Down Expand Up @@ -329,10 +341,21 @@ jobs:
subject-path: dist/deploy/wheels/pantsbuild.pants/**/pantsbuild.pants-*.whl
- if: needs.release_info.outputs.is-release == 'true'
name: Rename the Pants Pex to its final name for upload
run: 'PEX_FILENAME=pants.$PANTS_VER-$PY_VER-$PLAT.pex
run: 'PANTS_VER=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import
pants.version;print(pants.version.VERSION)")

PY_VER=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import
sys;print(f''cp{sys.version_info[0]}{sys.version_info[1]}'')")

PLAT=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import os;print(f''{os.uname().sysname.lower()}_{os.uname().machine.lower()}'')")

PEX_FILENAME=pants.$PANTS_VER-$PY_VER-$PLAT.pex


mv dist/src.python.pants/pants-pex.pex dist/src.python.pants/$PEX_FILENAME

echo "PEX_FILENAME=$PEX_FILENAME" >> "$GITHUB_ENV"

'
- continue-on-error: true
if: needs.release_info.outputs.is-release == 'true'
Expand All @@ -342,16 +365,11 @@ jobs:
subject-path: dist/src.python.pants/*.pex
- if: needs.release_info.outputs.is-release == 'true'
name: Upload Wheel and Pex
run: "PANTS_VER=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c \"\
import pants.version;print(pants.version.VERSION)\")\nPY_VER=$(PEX_INTERPRETER=1\
\ dist/src.python.pants/pants-pex.pex -c \"import sys;print(f'cp{sys.version_info[0]}{sys.version_info[1]}')\"\
)\nPLAT=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c \"import\
\ os;print(f'{os.uname().sysname.lower()}_{os.uname().machine.lower()}')\"\
)\nPEX_FILENAME=pants.$PANTS_VER-$PY_VER-$PLAT.pex\n\ncurl -L --fail \\\n\
\ -X POST \\\n -H \"Authorization: Bearer ${{ github.token }}\" \\\n\
\ -H \"Content-Type: application/octet-stream\" \\\n ${{ needs.release_info.outputs.release-asset-upload-url\
\ }}?name=$PEX_FILENAME \\\n --data-binary \"@dist/src.python.pants/$PEX_FILENAME\"\
\n\nWHL=$(find dist/deploy/wheels/pantsbuild.pants -type f -name \"pantsbuild.pants-*.whl\"\
run: "curl -L --fail \\\n -X POST \\\n -H \"Authorization: Bearer ${{\
\ github.token }}\" \\\n -H \"Content-Type: application/octet-stream\"\
\ \\\n ${{ needs.release_info.outputs.release-asset-upload-url }}?name=$PEX_FILENAME\
\ \\\n --data-binary \"@dist/src.python.pants/$PEX_FILENAME\"\n\nWHL=$(find\
\ dist/deploy/wheels/pantsbuild.pants -type f -name \"pantsbuild.pants-*.whl\"\
)\ncurl -L --fail \\\n -X POST \\\n -H \"Authorization: Bearer ${{ github.token\
\ }}\" \\\n -H \"Content-Type: application/octet-stream\" \\\n \"${{\
\ needs.release_info.outputs.release-asset-upload-url }}?name=$(basename $WHL)\"\
Expand Down Expand Up @@ -449,10 +467,21 @@ jobs:
subject-path: dist/deploy/wheels/pantsbuild.pants/**/pantsbuild.pants-*.whl
- if: needs.release_info.outputs.is-release == 'true'
name: Rename the Pants Pex to its final name for upload
run: 'PEX_FILENAME=pants.$PANTS_VER-$PY_VER-$PLAT.pex
run: 'PANTS_VER=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import
pants.version;print(pants.version.VERSION)")

PY_VER=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import
sys;print(f''cp{sys.version_info[0]}{sys.version_info[1]}'')")

PLAT=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import os;print(f''{os.uname().sysname.lower()}_{os.uname().machine.lower()}'')")

PEX_FILENAME=pants.$PANTS_VER-$PY_VER-$PLAT.pex


mv dist/src.python.pants/pants-pex.pex dist/src.python.pants/$PEX_FILENAME

echo "PEX_FILENAME=$PEX_FILENAME" >> "$GITHUB_ENV"

'
- continue-on-error: true
if: needs.release_info.outputs.is-release == 'true'
Expand All @@ -462,16 +491,11 @@ jobs:
subject-path: dist/src.python.pants/*.pex
- if: needs.release_info.outputs.is-release == 'true'
name: Upload Wheel and Pex
run: "PANTS_VER=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c \"\
import pants.version;print(pants.version.VERSION)\")\nPY_VER=$(PEX_INTERPRETER=1\
\ dist/src.python.pants/pants-pex.pex -c \"import sys;print(f'cp{sys.version_info[0]}{sys.version_info[1]}')\"\
)\nPLAT=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c \"import\
\ os;print(f'{os.uname().sysname.lower()}_{os.uname().machine.lower()}')\"\
)\nPEX_FILENAME=pants.$PANTS_VER-$PY_VER-$PLAT.pex\n\ncurl -L --fail \\\n\
\ -X POST \\\n -H \"Authorization: Bearer ${{ github.token }}\" \\\n\
\ -H \"Content-Type: application/octet-stream\" \\\n ${{ needs.release_info.outputs.release-asset-upload-url\
\ }}?name=$PEX_FILENAME \\\n --data-binary \"@dist/src.python.pants/$PEX_FILENAME\"\
\n\nWHL=$(find dist/deploy/wheels/pantsbuild.pants -type f -name \"pantsbuild.pants-*.whl\"\
run: "curl -L --fail \\\n -X POST \\\n -H \"Authorization: Bearer ${{\
\ github.token }}\" \\\n -H \"Content-Type: application/octet-stream\"\
\ \\\n ${{ needs.release_info.outputs.release-asset-upload-url }}?name=$PEX_FILENAME\
\ \\\n --data-binary \"@dist/src.python.pants/$PEX_FILENAME\"\n\nWHL=$(find\
\ dist/deploy/wheels/pantsbuild.pants -type f -name \"pantsbuild.pants-*.whl\"\
)\ncurl -L --fail \\\n -X POST \\\n -H \"Authorization: Bearer ${{ github.token\
\ }}\" \\\n -H \"Content-Type: application/octet-stream\" \\\n \"${{\
\ needs.release_info.outputs.release-asset-upload-url }}?name=$(basename $WHL)\"\
Expand Down
10 changes: 5 additions & 5 deletions src/python/pants_release/generate_github_workflows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,8 +932,13 @@ def build_wheels_job(
"if": "needs.release_info.outputs.is-release == 'true'",
"run": dedent(
"""\
PANTS_VER=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import pants.version;print(pants.version.VERSION)")
PY_VER=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import sys;print(f'cp{sys.version_info[0]}{sys.version_info[1]}')")
PLAT=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import os;print(f'{os.uname().sysname.lower()}_{os.uname().machine.lower()}')")
PEX_FILENAME=pants.$PANTS_VER-$PY_VER-$PLAT.pex

mv dist/src.python.pants/pants-pex.pex dist/src.python.pants/$PEX_FILENAME
echo "PEX_FILENAME=$PEX_FILENAME" >> "$GITHUB_ENV"
"""
),
},
Expand All @@ -956,11 +961,6 @@ def build_wheels_job(
# support. `curl` is a good lowest-common-denominator way to upload the assets.
"run": dedent(
"""\
PANTS_VER=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import pants.version;print(pants.version.VERSION)")
PY_VER=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import sys;print(f'cp{sys.version_info[0]}{sys.version_info[1]}')")
PLAT=$(PEX_INTERPRETER=1 dist/src.python.pants/pants-pex.pex -c "import os;print(f'{os.uname().sysname.lower()}_{os.uname().machine.lower()}')")
PEX_FILENAME=pants.$PANTS_VER-$PY_VER-$PLAT.pex

curl -L --fail \\
-X POST \\
-H "Authorization: Bearer ${{ github.token }}" \\
Expand Down
Loading