-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ghac): Bump opendal to support ghac v2 #21994
Conversation
Signed-off-by: Xuanwo <[email protected]>
Thank you, I've taken the initiative to add release notes. |
I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants. ❌ 2.24.xI was unable to cherry-pick this PR to 2.24.x, likely due to merge-conflicts. Steps to Cherry-Pick locallyTo resolve:
Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary. ✔️ 2.25.xSuccessfully opened #21997. When you're done manually cherry-picking, please remove the Thanks again for your contributions! |
…21997) Github is planning to sunset the legacy services before March 1st. This PR updates OpenDAL to version 0.52.0, which automatically supports GHAC v2. The ghac v2 requires using azblob to upload data internally, so we need to add some extra dependencies in this PR. Perhaps we can consider enabling both s3 and azblob support in the future since all dependencies have already been included. Refer to apache/opendal#5620 for more details. Signed-off-by: Xuanwo <[email protected]> Co-authored-by: Xuanwo <[email protected]> Co-authored-by: Huon Wilson <[email protected]>
Github is planning to sunset the legacy services before March 1st. This PR updates OpenDAL to version 0.52.0, which automatically supports GHAC v2. The ghac v2 requires using azblob to upload data internally, so we need to add some extra dependencies in this PR. Perhaps we can consider enabling both s3 and azblob support in the future since all dependencies have already been included. Refer to apache/opendal#5620 for more details. --------- Signed-off-by: Xuanwo <[email protected]> Co-authored-by: Huon Wilson <[email protected]>
Done the 2.24 cherry pick in #21998. Cherrypicking given the time-sensitivity. |
Thank you @huonw for taking care about this! |
Github is planning to sunset the legacy services before March 1st. This PR updates OpenDAL to version 0.52.0, which automatically supports GHAC v2.
The ghac v2 requires using azblob to upload data internally, so we need to add some extra dependencies in this PR. Perhaps we can consider enabling both s3 and azblob support in the future since all dependencies have already been included.
Refer to apache/opendal#5620 for more details.