Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ghac): Bump opendal to support ghac v2 #21994

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Feb 24, 2025

Github is planning to sunset the legacy services before March 1st. This PR updates OpenDAL to version 0.52.0, which automatically supports GHAC v2.

The ghac v2 requires using azblob to upload data internally, so we need to add some extra dependencies in this PR. Perhaps we can consider enabling both s3 and azblob support in the future since all dependencies have already been included.

Refer to apache/opendal#5620 for more details.

@sureshjoshi sureshjoshi requested review from huonw and benjyw February 24, 2025 13:05
@huonw
Copy link
Contributor

huonw commented Feb 24, 2025

Thank you, I've taken the initiative to add release notes.

@huonw huonw added this to the 2.24.x milestone Feb 24, 2025
@huonw huonw merged commit cdc20e1 into pantsbuild:main Feb 25, 2025
24 checks passed
@WorkerPants
Copy link
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

❌ 2.24.x

I was unable to cherry-pick this PR to 2.24.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

  1. (Ensure your git working directory is clean)
  2. Run the following script to reproduce the merge-conflicts:
    git fetch https://github.com/pantsbuild/pants main \
      && git fetch https://github.com/pantsbuild/pants 2.24.x \
      && git checkout -b cherry-pick-21994-to-2.24.x FETCH_HEAD \
      && git cherry-pick cdc20e1d85e443562975793703866825908d6c03
  3. Fix the merge conflicts and commit the changes
  4. Run build-support/cherry_pick/make_pr.sh "21994" "2.24.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

✔️ 2.25.x

Successfully opened #21997.


When you're done manually cherry-picking, please remove the needs-cherrypick label on this PR.

Thanks again for your contributions!

🤖 Beep Boop here's my run link

@WorkerPants WorkerPants added the auto-cherry-picking-failed Auto Cherry-Picking Failed label Feb 25, 2025
huonw added a commit that referenced this pull request Feb 25, 2025
…21997)

Github is planning to sunset the legacy services before March 1st. This
PR updates OpenDAL to version 0.52.0, which automatically supports GHAC
v2.

The ghac v2 requires using azblob to upload data internally, so we need
to add some extra dependencies in this PR. Perhaps we can consider
enabling both s3 and azblob support in the future since all dependencies
have already been included.

Refer to apache/opendal#5620 for more details.

Signed-off-by: Xuanwo <[email protected]>
Co-authored-by: Xuanwo <[email protected]>
Co-authored-by: Huon Wilson <[email protected]>
huonw added a commit that referenced this pull request Feb 25, 2025
Github is planning to sunset the legacy services before March 1st. This
PR updates OpenDAL to version 0.52.0, which automatically supports GHAC
v2.

The ghac v2 requires using azblob to upload data internally, so we need
to add some extra dependencies in this PR. Perhaps we can consider
enabling both s3 and azblob support in the future since all dependencies
have already been included.

Refer to apache/opendal#5620 for more details.

---------

Signed-off-by: Xuanwo <[email protected]>
Co-authored-by: Huon Wilson <[email protected]>
@huonw
Copy link
Contributor

huonw commented Feb 25, 2025

Done the 2.24 cherry pick in #21998.

Cherrypicking given the time-sensitivity.

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Feb 25, 2025

Thank you @huonw for taking care about this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants