s3: Load aws env vars from local environment #22008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| set_aws_env_vars(rule_runner, {"AWS_PROFILE": "profile1"}) | ||
| creds4 = rule_runner.request(AWSCredentials, []) | ||
| # N.B. Not totally sure why, but 'is' doesn't work here because of how set_options operates | ||
| assert creds1 == creds4 |
There was a problem hiding this comment.
I'm not totally happy with these tests as I couldn't get the assertions working that the exact same object is returned, but in local testing with pantsd it appears to work correctly
| @@ -48,7 +53,44 @@ async def access_aws_credentials() -> AWSCredentials: | |||
| ) | |||
| raise | |||
|
|
|||
| session = session.get_session() | |||
There was a problem hiding this comment.
was previously shadowing the import so I updated the import to an alias to avoid confusion
| }, | ||
| ) | ||
|
|
||
| session = boto_session.Session() |
There was a problem hiding this comment.
botocore session reference https://github.com/boto/botocore/blob/develop/botocore/session.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21168 #20624