Re-locked more JS dependencies #22032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sureshjoshi
added
category:internal
sureshjoshi
commented
Mar 2, 2025
| @@ -122,8 +124,8 @@ def configure_runner_with_js_project(request, rule_runner: RuleRunner) -> RuleRu | |||
| "scripts": { | |||
| "build": "parcel build index.mjs --dist-dir=dist --cache-dir=.parcel-cache" | |||
| }, | |||
| "dependencies": {"child-lib": "*"}, | |||
| "devDependencies": {"parcel": "^2.12.0"}, | |||
| "dependencies": {"child-lib": child_dep}, | |||
There was a problem hiding this comment.
I needed to do this, because pnpm/yarn/npm don't all seem to like the same specification of workspace dependencies (anymore?)
sureshjoshi
commented
Mar 2, 2025
There was a problem hiding this comment.
This project doesn't package - and it didn't seem to package earlier, due to a missing esbuild. I'll see where CI takes us, but it looks like tsx dep inference wasn't working.
tdyas
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #22027, trying to calm Dependabot down - but I missed some on the last PR.