migrate to packaging requirements parsing from deprecated pkg_resources
#22033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
added
category:internal
tdyas
removed
the
release-notes:not-required
tdyas
changed the title
packaging requirements instead of pkg_resourcespackaging requirements library from deprecated pkg_resources
tdyas
changed the title
packaging requirements library from deprecated pkg_resourcespackaging requirements parsing from deprecated pkg_resources
tdyas
commented
Mar 5, 2025
| @@ -490,7 +489,6 @@ def test_partition_into_major_minor_versions(constraints: list[str], expected: l | |||
| (["==3.0.*"], (3, 0)), | |||
| (["==3.45.*"], (3, 45)), | |||
| ([">=3.45,<3.46"], (3, 45)), | |||
| ([">=3.45.*,<3.46.*"], (3, 45)), | |||
There was a problem hiding this comment.
Removed since .* syntax with operators other than == and != is not accepted.
| @@ -514,7 +512,6 @@ def test_partition_into_major_minor_versions(constraints: list[str], expected: l | |||
| ([">3.45,<=3.46"], None), | |||
| ([">3.45,<3.47"], None), | |||
| (["===3.45"], None), | |||
| ([">=3.45,<=3.45.*"], None), | |||
There was a problem hiding this comment.
Removed since .* syntax with operators other than == and != is not accepted.
benjyw
reviewed
Mar 5, 2025
src/python/pants/backend/python/util_rules/interpreter_constraints.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Benjy Weinberger <[email protected]>
Co-authored-by: Benjy Weinberger <[email protected]>
benjyw
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to use
Requirementfrompackaginginstead of the deprecatedpkg_resources.The
project_nameattribute is callednamebypackaging.requirements.Requirementso migrate Pants naming to use that, except in lock files where we keep theproject_namenaming to avoid breaking existing lockfiles.Note in the release notes that the
.*pattern is only permitted with==and!=operators.pkg_resourcesaccepted.*patterns with other operators which is not permitted by the current versioning specification.