fix CI "build wheels" step for rustup no longer installing default toolchain #22037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
added
category:internal
tdyas
changed the title
This was referenced Mar 3, 2025
Merged
tdyas
changed the title
huonw
approved these changes
Mar 4, 2025
tdyas
added a commit
that referenced
this pull request
Mar 4, 2025
…olchain (Cherry-pick of #22037) (#22038) Fix the "Build wheels" step for a breaking change in [Rustup v1.28.0](https://blog.rust-lang.org/2025/03/02/Rustup-1.28.0.html) which no longer installs a default toolchain any more. Use `rustup default` to install the applicable toolchain because it is idempotent and will install the toolchain if it is not already installed. `rustup toolchain install` by design will try to install even if the toolchain is already installed. See rust-lang/rustup#710 for discussion of this distinction. Closes #22036 --------- Co-authored-by: Tom Dyas <[email protected]>
tdyas
added a commit
that referenced
this pull request
Mar 4, 2025
…olchain (Cherry-pick of #22037) (#22039) Fix the "Build wheels" step for a breaking change in [Rustup v1.28.0](https://blog.rust-lang.org/2025/03/02/Rustup-1.28.0.html) which no longer installs a default toolchain any more. Use `rustup default` to install the applicable toolchain because it is idempotent and will install the toolchain if it is not already installed. `rustup toolchain install` by design will try to install even if the toolchain is already installed. See rust-lang/rustup#710 for discussion of this distinction. Closes #22036 --------- Co-authored-by: Tom Dyas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the "Build wheels" step for a breaking change in Rustup v1.28.0 which no longer installs a default toolchain any more.
Use
rustup defaultto install the applicable toolchain because it is idempotent and will install the toolchain if it is not already installed.rustup toolchain installby design will try to install even if the toolchain is already installed. See rust-lang/rustup#710 for discussion of this distinction.Closes #22036