Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check in Rust parser whether string candidates are valid dotted names #22066

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Mar 9, 2025

As reported in #20324, the Rust dependency inference parser does not check whether string candidates (when string_imports = true is in effect) are valid dotted Python names.

While the Python-side of the dependency inference logic does now check (as of #20472), it is easy enough to support this in Rust using the tree-sitter grammar.

cognifloyd
cognifloyd previously approved these changes Mar 9, 2025
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like like there's a loop or a hang or a race condition, add lint failed miserably.

@cognifloyd cognifloyd dismissed their stale review March 9, 2025 22:23

Wait for green ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bugfix Bug fixes for released features needs-cherrypick release-notes:not-required PR doesn't require mention in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants