re-enable test_pantsd_memory_usage#23292
Open
cburroughs wants to merge 1 commit intopantsbuild:mainfrom
Open
Conversation
I ran this test 500 times and was unable to reproduce the original issue. It may have been fixed by pantsbuild#9999 The assertion change is to make sure current_memory_usage worked so we get something better than a divide by zero error in the next assertion if not. The prior assertion had the side effect of failing the test if memory usage ever *decreased*, which doesn't make sense. If we added better GC that would be good! closes pantsbuild#8193
cburroughs
added
the
release-notes:not-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran this test 500 times and was unable to reproduce the original issue. It may have been fixed by #9999
The assertion change is to make sure current_memory_usage worked so we get something better than a divide by zero error in the next assertion if not. The prior assertion had the side effect of failing the test if memory usage ever decreased, which doesn't make sense. If we added better GC that would be good!
closes #8193