Add workaround for release publishing action mishandling draft: true
-> false
transition
#444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around
softprops/action-gh-release
not being able to properly "publish" a release by changingdraft: true
todraft: false
.The intention is that the step with
draft: false
would find the existing draft release and update it (publishing it). This is what correctly happened for a testingv0.12.3-beta.3
release from this branch: https://github.com/pantsbuild/scie-pants/releases/tag/v0.12.3-beta.3 (I also did attempted av0.12.3-beta.2
from this branch, but that used a newer version of the action code and failed completely, see below.)Previously, the action would fail to find the existing draft release and instead create a duplicate one. The old behaviour is visible (to people who can see draft releases) with
v0.12.3-beta.0
and-beta.1
:The particular new version of the action is:
v2
tag) with fix: updating release draft status from true to false softprops/action-gh-release#316 merged inRequest body length does not match content-length header
, so this sticks with the older version.