Allow passing URLSearchParams directly to implicitAuthentication#817
Allow passing URLSearchParams directly to implicitAuthentication#817nwalters512 wants to merge 1 commit intopanva:mainfrom
Conversation
There was a problem hiding this comment.
I couldn't figure out how to get these tests to run locally. Even when running npm run tap:node locally, every test fails with the following:
message: "Promise rejected during \"end-to-end w/ response_type=id_token, implicit, form_post, error_response\": unexpected HTTP response status code"
Any guidance would be helpful!
|
Hello @nwalters512 I'm not sure in what case the existing inputs aren't "usable". The examples cover the use cases I have in mind. |
|
"When using a form_post response mode without a Request instance" from those docs matches my scenario. While that works, it's simply very clunky to require one to construct a full URL. It seems especially silly given that I should have said this PR makes it more usable (or rather, more ergonomic). |
Given that the function is already using
URLSearchParamsinternally, it seems like a natural extension to allow one to pass an instance ofURLSearchParamsif they already have it. This makesimplicitAuthenticationusable even when one doesn't have a webRequestobject.