Fix unloaded HTMLImageElement uniforms - #277
Merged
Merged
Conversation
|
@teeverc is attempting to deploy a commit to the Paper Design Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
thanks, looks good. |
itsdouges
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wait for
HTMLImageElementuniforms to finish decoding before passing them to the vanillaShaderMount.Fixes race condition:
Uncaught (in promise) Error: Paper Shaders: image for uniform u_noiseTexture must be fully loadedfor cache miss.Problem
Some shaders create image uniforms internally, such as the embedded
u_noiseTexture.processUniformscurrently passes these images through immediately, even if they have not finished loading.On a cold page load, WebGL can therefore receive an image with a zero
naturalWidthand throw:Change
Use
HTMLImageElement.decode()and add its promise to the existingimageLoadPromisescollection. This uses the same waiting mechanism already used for string image uniforms.This is a follow-up to #244 and #253.
Verification
bun run buildbun run --filter @paper-design/shaders-react type-checkGrainGradientcold-load failure in a React application