Add reify_original method.
#1504
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
This PR has been automatically marked as stale due to inactivity. |
joshuapinter
force-pushed
the
add_reify_original
branch
from
607aea8 to
aed329e
Compare
Returning the original version is a common use-case and is not as easy as it should be, particularly because calling `reify` on the first version returns `nil`, which is the `object` *before* it was created. This method simply tries to `reify` from the *second* version, if it exists. If it doesn’t exist (i.e. there has not been any changes to the object), it falls back to `self`, which is the original and *only* version of the object. Added specs to document, legacy widget and widget. Fixes paper-trail-gem#1204.
joshuapinter
force-pushed
the
add_reify_original
branch
from
aed329e to
50a3b7a
Compare
|
Okay, I've added specs and an entry into the CHANGELOG. This PR should be ready for review and merging. Let me know if you would like to see any changes. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning the original version is a common use-case and is not as easy as it should be, particularly because calling
reifyon the first version returnsnil, which is theobjectbefore it was created.This method simply tries to
reifyfrom the second version, if it exists. If it doesn’t exist (i.e. there has not been any changes to the object), it falls back toself, which is the original and only version of the object.Fixes #1204.
Thank you for your contribution!
Check the following boxes:
master(if not - rebase it).code introduces user-observable changes.
and description in grammatically correct, complete sentences.