Skip to content

Add as development dependencies gems extracted from Ruby stdlib #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

Add as development dependencies gems extracted from Ruby stdlib #1512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
945d691
Add as development dependencies gems extracted from Ruby stdlib
davidrunger Mar 18, 2025
0ebc058
Add empty commit to trigger GitHub Actions build
davidrunger Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions paper_trail.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,14 @@ has been destroyed.
# PT supports request_store versions for 3 years.
s.add_dependency "request_store", "~> 1.4"

# The following gems have been extracted from the Ruby stdlib to gems, and we
# must manually include them here in order for specs to run.
s.add_development_dependency "benchmark", "~> 0.4.0"
s.add_development_dependency "bigdecimal", "~> 3.1"
s.add_development_dependency "drb", "~> 2.2"
s.add_development_dependency "logger", "~> 1.6"
s.add_development_dependency "mutex_m", "~> 0.3.0"
Comment on lines +61 to +65
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure of the best way to determine which version specifiers to write here.

For each gem, I looked at the latest version available (at rubygems.org).

If the latest version has a major version of 0, then I did ~> <latest version>.

If the latest version has a non-zero major version, then I did ~> <major.minor of latest version>.

I have little idea if this is an optimal algorithm, and would be happy to make any changes.


s.add_development_dependency "appraisal", "~> 2.5"
s.add_development_dependency "byebug", "~> 11.1"
s.add_development_dependency "ffaker", "~> 2.20"
Expand Down
3 changes: 2 additions & 1 deletion spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@
Bundler.setup

# Then, the chosen components of Rails would be loaded. In our case, we only
# test with AR and AC.
# test with AR and AC. We require `logger` because `active_record` needs it.
require "logger"
require "active_record/railtie"
require "action_controller/railtie"

Expand Down
Loading