Skip empty versions#1552
Open
Artinens wants to merge 18 commits intopaper-trail-gem:masterfrom
Open
Conversation
…ail-gem#1499) Co-authored-by: fatkodima <fatkodima123@gmail.com>
…r-trail-gem#1512) * Add as development dependencies gems extracted from Ruby stdlib Specs are currently failing on `master` on my local machine when I try to run specs with `BUNDLE_GEMFILE=/home/david/code/paper_trail/gemfiles/rails_6.1.gemfile bundle exec rspec`. This isn't yet reflected in any CI builds on `master`, but I believe that it would be, if a build were to be triggered on `master`. The same error is also occurring in recent PRs that have been put up (e.g. [this PR][1] with [this failed build][2] and [this PR][3] with [this failed build][4]). [1]: paper-trail-gem#1509 [2]: https://github.com/paper-trail-gem/paper_trail/actions/runs/13835939334/job/38733099092?pr=1509 [3]: paper-trail-gem#1511 [4]: https://github.com/paper-trail-gem/paper_trail/actions/runs/13916744592/job/38941085149?pr=1511 I'm not sure why these errors have started occurring now, without any changes in `master` since [the last commit on `master`][5] that passed all checks. Maybe `bundler` changed its behavior, and we are pulling in a new/recent version of `bundler` with some relevant behavior change? [5]: paper-trail-gem@94e9c0d But, anyway, the errors seem to be caused by the extraction of various gems from the Ruby standard library into standalone gems, specifically: 1. `bigdecimal` 1. `drb` 1. `mutex_m` This change adds those gems as development dependencies of `paper_trail`. Although they are not yet causing errors, the following gems were causing a warning for me when I ran specs using Ruby 3.4.2 with `BUNDLE_GEMFILE=/home/david/code/paper_trail/gemfiles/rails_6.1.gemfile bundle exec rspec`: 1. `benchmark` 1. `logger` These are the warnings: > /home/david/code/paper_trail/spec/spec_helper.rb:64: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. > You can add logger to your Gemfile or gemspec to silence this warning. > /home/david/.rbenv/versions/3.4.2/lib/ruby/gems/3.4.0/gems/activesupport-6.1.7.10/lib/active_support/dependencies.rb:299: warning: benchmark was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. > You can add benchmark to your Gemfile or gemspec to silence this warning. > Also please contact the author of activesupport-6.1.7.10 to request adding benchmark into its gemspec. To avoid these warnings, I am also adding these two gems as development dependencies. Additionally, this change adds a `require "logger"` statement to `spec/spec_helper.rb`. This isn't needed for the other gems (I'm guessing because `activerecord` and/or `actionpack` have `require` statements for `bigdecimal`, `drb`, and `mutex_m`?), but it seems to be needed for `logger`; without it, we get an error when trying to boot specs about `NameError: uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger`. * Add empty commit to trigger GitHub Actions build
* Upgrade rubocop + rubocop plugins * run unsafe autofix on newly added todo items * Revert "run unsafe autofix on newly added todo items" This reverts commit d80e696. * autofix RSpec/BeEq * unsafe autofix all spec issues _except_ RSpec/Rails/InferredSpecType * Revert "unsafe autofix all spec issues _except_ RSpec/Rails/InferredSpecType" This reverts commit 7448551. * autofix RSpec/DescribedClass * autofix RSpec/ExpectChange * fix RSpec/ExampleWording * fix RSpec/NoExpectationExample * autofix RSpec/Rails/InferredSpecType * Revert "autofix RSpec/Rails/InferredSpecType" This reverts commit 73da18a. * try RSpec/Rails/InferredSpecType again * reorder Gemspec/RequireMFA * fix RSpec/VerifiedDoubleReference * fix Rails/RedundantActiveRecordAllMethod * fix Gemspec/DevelopmentDependencies * Revert "fix Gemspec/DevelopmentDependencies" This reverts commit f73c2af. * disable Gemspec/DevelopmentDependencies * fix Performance/MapMethodChain * explicitly disable Security/YAMLLoad * fix Style/ConcatArrayLiterals * enable / fix -Gemspec/RequireMFA * explicitly disable Rails/ApplicationRecord * remove configuration for RSpec/Rails/InferredSpecType, add config.infer_spec_type_from_file_location! to rspec * add spaces * disable Style/FetchEnvVar * revert RSpec/BeEq changes and disable * revert / disable Rails/Delegate
* Drop rails 6.1/7.0 and ruby 3.0/3.1 support * upgrade rubocop-rspec + rspec-rails * disable RSpec/IndexedLet * autofix RSpec/IndexedLet * auto-fix Style/ArrayIntersect * autofix RSpec/ReceiveMessages * autofix RSpec/MetadataStyle * revert changes from bad rebase * revert .rubocop_todo.yml changes * empty line
i missed this in paper-trail-gem#1513
…em#1528) - add argument to install generator - add test for the filenames of the migration - add custom version class support to update_item_subtype generator (via option) Co-authored-by: Benjamin Deutscher <ben@byder.io>
* Add rails 8.1.beta to Appraisals * try moving rails-controller-testing into gemspec * regenerate gemfiles
Co-authored-by: Leo Arnold <opensource@leoarnold.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
Check the following boxes:
master(if not - rebase it).code introduces user-observable changes.
and description in grammatically correct, complete sentences.