Fix company import label portability#4172
Closed
starlessrider wants to merge 1 commit intopaperclipai:masterfrom
Closed
Fix company import label portability#4172starlessrider wants to merge 1 commit intopaperclipai:masterfrom
starlessrider wants to merge 1 commit intopaperclipai:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
What Changed
.paperclip.yamlas label definitions.labelSlugsinstead of raw source-companylabelIds.labelIdssafe: preserve them only when they already exist in the target company, otherwise skip them with a warning instead of passing invalid ids into issue creation.Verification
pnpm test:run cli/src/__tests__/company.test.ts server/src/__tests__/company-portability.test.ts server/src/__tests__/company-portability-routes.test.tspnpm typecheckNo UI surface changed; screenshots are not applicable.
Risks
labelsandlabelSlugsto the portable manifest while retaininglabelIdsas legacy-compatible input.labelIdscannot preserve labels when imported into a different company unless matching label ids already exist in the target; those labels are now skipped with a warning instead of failing the import.Model Used
Checklist