Skip to content

chore(runtime): correct spec.runtime deprecation to v0.1.19 + kubectl-explain marker #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stubbi merged 1 commit into from
Jun 19, 2026
Merged

chore(runtime): correct spec.runtime deprecation to v0.1.19 + kubectl-explain marker #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions api/v1/hermesinstance_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,9 @@ type HermesInstanceSpec struct {
// the operator no longer builds a runtime via init containers. Setting this
// has no effect.
//
// Deprecated: ignored since the upstream-image runtime (v0.1.18); scheduled
// Deprecated: ignored since the upstream-image runtime (v0.1.19); scheduled
// for removal no earlier than v0.3.0 and 2027-01-01. See docs/deprecations.md.
// +kubebuilder:validation:Description="DEPRECATED: ignored - the agent image is the self-contained upstream NousResearch/hermes-agent runtime (no init-container build). Removal no earlier than v0.3.0 / 2027-01-01. See docs/deprecations.md."
// +optional
Runtime RuntimeSpec `json:"runtime,omitempty"`

Expand Down Expand Up @@ -1179,7 +1180,7 @@ type HermesInstanceList struct {
// RuntimeSpec controlled Python/uv runtime concerns for the old hand-rolled agent
// image's init-container build.
//
// Deprecated: ignored since the upstream-image runtime (v0.1.18); the upstream
// Deprecated: ignored since the upstream-image runtime (v0.1.19); the upstream
// agent image is self-contained. Scheduled for removal no earlier than v0.3.0 and
// 2027-01-01. See docs/deprecations.md.
type RuntimeSpec struct {
Expand Down
2 changes: 1 addition & 1 deletion charts/hermes-operator/templates/crds/hermes.agent_hermesinstances.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5605,7 +5605,7 @@ spec:
image is the upstream NousResearch/hermes-agent s6 runtime, which is
self-contained (see docs/runtime.md). Setting this has no effect.

Deprecated: ignored since the upstream-image runtime (v0.1.18); scheduled
Deprecated: ignored since the upstream-image runtime (v0.1.19); scheduled
for removal no earlier than v0.3.0 and 2027-01-01. See docs/deprecations.md.
properties:
extraAptPackages:
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/hermes.agent_hermesinstances.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5605,7 +5605,7 @@ spec:
image is the upstream NousResearch/hermes-agent s6 runtime, which is
self-contained (see docs/runtime.md). Setting this has no effect.

Deprecated: ignored since the upstream-image runtime (v0.1.18); scheduled
Deprecated: ignored since the upstream-image runtime (v0.1.19); scheduled
for removal no earlier than v0.3.0 and 2027-01-01. See docs/deprecations.md.
properties:
extraAptPackages:
Expand Down
4 changes: 2 additions & 2 deletions docs/api-reference-generated.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ _Appears in:_
| `restoreFrom` _string_ | RestoreFrom names a backup snapshot to restore from on next boot. | | Optional: \{\} <br /> |
| `autoUpdate` _[AutoUpdateSpec](#autoupdatespec)_ | AutoUpdate controls opt-in OCI-registry polling for newer agent images. | | Optional: \{\} <br /> |
| `migration` _[MigrationSpec](#migrationspec)_ | Migration is a one-shot migration source (set on initial create only). | | Optional: \{\} <br /> |
| `runtime` _[RuntimeSpec](#runtimespec)_ | Runtime configured the agent's Python toolchain and OS-level dependencies<br />for the old hand-rolled agent image. It is now IGNORED: the published agent<br />image is the upstream NousResearch/hermes-agent s6 runtime, which ships its<br />own Python env, browser, node, and dependencies (see docs/runtime.md), so<br />the operator no longer builds a runtime via init containers. Setting this<br />has no effect.<br />Deprecated: ignored since the upstream-image runtime (v0.1.18); scheduled<br />for removal no earlier than v0.3.0 and 2027-01-01. See docs/deprecations.md. | | Optional: \{\} <br /> |
| `runtime` _[RuntimeSpec](#runtimespec)_ | Runtime configured the agent's Python toolchain and OS-level dependencies<br />for the old hand-rolled agent image. It is now IGNORED: the published agent<br />image is the upstream NousResearch/hermes-agent s6 runtime, which ships its<br />own Python env, browser, node, and dependencies (see docs/runtime.md), so<br />the operator no longer builds a runtime via init containers. Setting this<br />has no effect.<br />Deprecated: ignored since the upstream-image runtime (v0.1.19); scheduled<br />for removal no earlier than v0.3.0 and 2027-01-01. See docs/deprecations.md. | | Optional: \{\} <br /> |
| `gateways` _[GatewaysSpec](#gatewaysspec)_ | Gateways configures the platform-side messaging bindings (Telegram, Discord,<br />Slack, WhatsApp, Signal). Each gateway is opt-in and references its own<br />Secret(s) so tokens are rotatable independently. | | Optional: \{\} <br /> |
| `profileStore` _[ProfileStoreSpec](#profilestorespec)_ | ProfileStore configures the optional Honcho profile-store companion. | | Optional: \{\} <br /> |
| `tailscale` _[TailscaleSpec](#tailscalespec)_ | Tailscale exposes the gateway over a Tailscale tailnet. | | Optional: \{\} <br /> |
Expand Down Expand Up @@ -1114,7 +1114,7 @@ _Appears in:_
RuntimeSpec controlled Python/uv runtime concerns for the old hand-rolled agent
image's init-container build.

Deprecated: ignored since the upstream-image runtime (v0.1.18); the upstream
Deprecated: ignored since the upstream-image runtime (v0.1.19); the upstream
agent image is self-contained. Scheduled for removal no earlier than v0.3.0 and
2027-01-01. See docs/deprecations.md.

Expand Down
2 changes: 1 addition & 1 deletion docs/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ deprecated surface:

| Surface | Type | Deprecated in | Replaced by | Earliest removal | Status |
|---|---|---|---|---|---|
| `spec.runtime` (`RuntimeSpec`: `python`/`uv`/`apt`/`pip`) | API field | v0.1.18 | n/a — the agent image is the self-contained upstream runtime (no init-container build); see [runtime.md](runtime.md) | v0.3.0 / 2027-01-01 | Ignored |
| `spec.runtime` (`RuntimeSpec`: `python`/`uv`/`apt`/`pip`) | API field | v0.1.19 | n/a — the agent image is the self-contained upstream runtime (no init-container build); see [runtime.md](runtime.md) | v0.3.0 / 2027-01-01 | Ignored |

## Historical removals

Expand Down
2 changes: 1 addition & 1 deletion internal/webhook/webhook_hermesinstance_validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ func validateCommon(inst *hermesv1.HermesInstance) (admission.Warnings, error) {
warns = append(warns, "spec.config.raw and spec.config.configMapRef are both set without spec.config.mergeMode; defaults to 'replace' (Raw wins)")
}

// Deprecated (v0.1.18): spec.runtime is ignored — the agent image is the
// Deprecated (v0.1.19): spec.runtime is ignored — the agent image is the
// self-contained upstream runtime, so there is no init-container Python build.
if !reflect.DeepEqual(inst.Spec.Runtime, hermesv1.RuntimeSpec{}) {
warns = append(warns, "spec.runtime is deprecated and ignored: the agent image is the self-contained upstream NousResearch/hermes-agent runtime (no init-container build). Remove spec.runtime; it is scheduled for removal no earlier than v0.3.0 and 2027-01-01. See docs/deprecations.md.")
Expand Down
Loading