Skip to content

Changed touch detection for Workspace button #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Thesola10
Copy link
Collaborator

This fixes #992 by triggering the button action at the start of the touch event, rather than at the end.

@ShamrockLee please test

Copy link

Thanks for your contribution! We don't accept pull requests to the release branch. I have rebased your pull request onto develop, check for any conflicts.

@github-actions github-actions bot changed the base branch from release to develop March 27, 2025 19:20
@ShamrockLee
Copy link

Thank you very much for being so patient. I recently updated the SSD of my tablet and is now reinstalling the system. It would take some time before I could test this.

As for the change, I hope that we could eventually find a solution that uses the up-event instead of the down-event for short tapping buttons in the long run. A button triggered by the up-event allows aborting by dragging the touch pointer away from the button before lifting, and is therefore more fault-tolerant and more accessible to users with physical disability (ref. WCAG 2.1 2.5.2 Pointer Cancellation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Workspace" button doesn't work on touch screen
2 participants