fix: proper background for 'prefer-light' color-scheme #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Do i need to do anything on my end? Perhaps, rebase my release branch to upstream develop branch? Or can close this PR and reopen with proper branches usage if needed. P.S.: sorry for using release branch in the first place, somehow missed that there were develop branch. |
Collaborator
|
no it's okay, right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous logic for handling which picture uri to use based on the system theme were only checking for 'default' and fallbaking to dark in all other cases. That caused a bug, where if system is in 'prefer-light', it would render wallpaper for dark theme(picture-uri-dark).
This PR fixes it.