ci: Consolidate permissions at workflow level - #16
Merged
Conversation
Standardize on a single workflow-level permissions block per workflow rather than a mix of workflow- and job-level declarations. Where a job declared its own block, the workflow-level block is the union of what every job needs, since job-level permissions replace workflow-level rather than merging with it. Claude-Session: https://claude.ai/code/session_01Rg3UBFSnmKMPQLNpNKkn8d
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage 88.16% 88.16%
=======================================
Files 4 4
Lines 2365 2365
=======================================
Hits 2085 2085
Misses 280 280 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
📊 Benchmark ComparisonClick to expand benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardizes on a single workflow-level
permissions:block per workflow, rather than a mix of workflow- and job-level declarations, so every workflow declares its scopes in one predictable place.Where a job declared its own block, the workflow-level block is the union of what every job needs (job-level
permissions:replaces workflow-level rather than merging with it, so the union is what preserves current behaviour).No job loses a scope. In multi-job workflows some jobs gain one they don't use — noted per-repo in the commit message. Fork pull requests always receive a read-only
GITHUB_TOKENregardless of repository settings, so any widened scope is only reachable from branches by users who already have write access.Part of the workflow-permissions hardening ahead of switching the org default workflow permissions to read-only.
https://claude.ai/code/session_01Rg3UBFSnmKMPQLNpNKkn8d