test: Remove unhelpful/inaccurate tests - #117
Merged
Merged
Conversation
isaacvando
requested review from
mdashti,
philippemnoel,
rebasedming and
stuhood
as code owners
May 5, 2026 14:28
philippemnoel
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
What
These tests were mostly testing the behavior of the DB rather than the ORM. The reason the assertions started failing in 0.23.3 is that the tests were asserting that facet results contained
__PDB_NULL__which seems to be a bug. This bug was fixed so the queries now correctly return normalnull. This looks like AI generation gone awry.Why
How
Tests