feat: codex review changes - #12
Merged
Merged
Conversation
ankitml
requested review from
mdashti,
philippemnoel,
rebasedming and
stuhood
as code owners
February 3, 2026 22:08
| # Simple AND search (multiple strings allowed) | ||
| ParadeDB('running', 'shoes') | ||
|
|
||
| # Boolean logic (PQ must be SOLE argument) |
Member
There was a problem hiding this comment.
Is this a Django requirement?
Contributor
Author
There was a problem hiding this comment.
yes. It is how Django's Q objects behave https://docs.djangoproject.com/en/6.0/topics/db/queries/#complex-lookups-with-q
Our PQ object mirrors default Q object.
philippemnoel
approved these changes
Feb 3, 2026
ankitml
force-pushed
the
ankitmldesign-doc-review
branch
from
February 4, 2026 02:14
1167b5a to
4398601
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
Codex reviewed the implementation and requested these changes.
ParadeDB('a', 'b')) vs explicit PQ objects for OR/complex logic@overloadsignatures toParadeDBclass for better IDE autocomplete and type checkingWhat
Why
How
Tests