Skip to content

test: Consolidate tests - #126

Merged
isaacvando merged 26 commits into
mainfrom
consolidate-test-code
May 21, 2026
Merged

test: Consolidate tests#126
isaacvando merged 26 commits into
mainfrom
consolidate-test-code

Conversation

@isaacvando

@isaacvando isaacvando commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Ticket(s) Closed

  • Deletes many unnecessary tests (e.g. just testing the DB or Django with nothing to do with the ORM).
  • Consolidates many other tests into more focused files.
  • Updates most tests to assert against full generated SQL and run the query. This validates that the generated SQL is valid and uncovered some tests that were generating invalid SQL that could be removed.

Goes from 545 tests to 274 tests while keeping code coverage at 90%.

What

Why

How

Tests

@isaacvando
isaacvando marked this pull request as draft May 20, 2026 22:14
@isaacvando isaacvando changed the title tests: Consolidate tests test: Consolidate tests May 20, 2026
@isaacvando
isaacvando force-pushed the consolidate-test-code branch from feea430 to e3ef98e Compare May 20, 2026 22:15
@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.25%. Comparing base (a57ce99) to head (6859f06).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   90.25%   88.25%   -2.00%     
==========================================
  Files          11        9       -2     
  Lines        1272     1209      -63     
  Branches      268      254      -14     
==========================================
- Hits         1148     1067      -81     
- Misses         76       83       +7     
- Partials       48       59      +11     
Flag Coverage Δ
dj4.2 88.25% <ø> (-2.00%) ⬇️
dj5.2 88.25% <ø> (-2.00%) ⬇️
dj6.0 88.25% <ø> (-2.00%) ⬇️
django-paradedb 88.25% <ø> (-2.00%) ⬇️
pg15 88.25% <ø> (-2.00%) ⬇️
pg16 88.25% <ø> (-2.00%) ⬇️
pg17 88.25% <ø> (-2.00%) ⬇️
pg18 88.25% <ø> (-2.00%) ⬇️
py3.10 88.25% <ø> (-2.00%) ⬇️
py3.11 88.25% <ø> (-2.00%) ⬇️
py3.12 88.25% <ø> (-2.00%) ⬇️
py3.13 88.25% <ø> (-2.00%) ⬇️
py3.14 88.25% <ø> (-2.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
paradedb/functions.py 91.66% <ø> (-6.78%) ⬇️
paradedb/queryset.py 77.33% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@isaacvando
isaacvando marked this pull request as ready for review May 21, 2026 14:29
@isaacvando
isaacvando merged commit 831c473 into main May 21, 2026
25 checks passed
@isaacvando
isaacvando deleted the consolidate-test-code branch May 21, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants