feat: Create a Demo Django website for quick demo / testing#71
Open
FlipperPA wants to merge 7 commits intoparadedb:mainfrom
Open
feat: Create a Demo Django website for quick demo / testing#71FlipperPA wants to merge 7 commits intoparadedb:mainfrom
FlipperPA wants to merge 7 commits intoparadedb:mainfrom
Conversation
Collaborator
|
This is supercool. Having and end to end example in there make everything visual. Would you consider it okay to make it part of examples instead of making test an app? Although I wouldnt worry about existing examples since they are runnable code snippets and not a django app in themselves.. But something like this could be a good option and then in examples/Readme.md the instructions can be something like what do you think? |
Author
|
Sure, that might be better in the long run, @ankitml. It might also be better to have some full-text examples; we could pull a few chapters of a public domain book from Gutenberg or something like that. I was just trying to keep the amount of extra code to maintain to a minimum, but we can still keep it pretty lean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This structure creates a minimal Django website we can use as a demo and for testing new features.
Why
This pattern allows for quick testing with a browser during feature development.
How
Added a Django app. I'm sure there are ways we can improve the installation process in the README, but I started with raw SQL at the
psqlCLI. I kept the single view in theurls.pyfile, just for simplicity. We can iterate on this moving forward.Tests
Passes the suite.