chore: remove stale repo files and refresh slnx - #36
Merged
Conversation
Cleanup of leftover files from before the namespace/package renames (PRs #29 and #30) and the workflow refactor (#34). Delete: - EFCore.ParadeDB.PgSearch.sln.DotSettings, EFCore.PgSearch.sln.DotSettings, ParadeDB.EntityFrameworkCore.sln.DotSettings — Rider/ReSharper settings files tied to solution names that no longer exist. - dotnet-tools.json (root) — empty {"tools": {}} stub superseded by .config/dotnet-tools.json, which is the canonical local tool manifest location and is what `dotnet tool restore` reads. Rename: - ParadeDB.EFCore.sln.DotSettings -> ParadeDB.EFCore.slnx.DotSettings so Rider matches it to the current ParadeDB.EFCore.slnx solution. Update ParadeDB.EFCore.slnx: - Drop the now-deleted dotnet-tools.json reference. - Replace publish.yml (removed in #34) with release.yml. - Add the new lint workflows and root scaffolding (CHANGELOG, CLAUDE, CONTRIBUTING, NUGET-README, RELEASE) to the IDE Solution folder so they surface in Rider/VS. A full sweep of src/ParadeDB.EFCore/ for unused public APIs / dead code turned up nothing — every public type, factory method, enum member, translator, and internal type-mapping is referenced from tests, examples, or the DI-registered query pipeline. The library source is left untouched. assets/paradedb-logo.png is intentionally kept: it's still packed into the NuGet package as <PackageIcon> via src/Directory.Build.props.
philippemnoel
requested review from
isaacvando,
mdashti,
rebasedming and
stuhood
as code owners
May 12, 2026 23:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Janitorial cleanup of files left behind by earlier renames (PRs #29 and #30) and the workflow refactor (#34).
Delete
EFCore.ParadeDB.PgSearch.sln.DotSettings,EFCore.PgSearch.sln.DotSettings,ParadeDB.EntityFrameworkCore.sln.DotSettings— Rider/ReSharper per-solution settings files tied to solution names that no longer exist (the live solution isParadeDB.EFCore.slnx).dotnet-tools.json(root) — empty{"tools": {}}stub. The active manifest is.config/dotnet-tools.json, which is the canonical locationdotnet tool restorereads from (and what the newlintjob in CI uses to load csharpier).Rename
ParadeDB.EFCore.sln.DotSettings→ParadeDB.EFCore.slnx.DotSettingsso Rider matches it to the current.slnxsolution file. (Contents: a small spelling dictionary withparadedb,jieba,Stopwords.)*.DotSettingsfiles had near-identical content. The end state is correct — one settings file at the new name, three deletions.Update
ParadeDB.EFCore.slnxdotnet-tools.jsonreference; add.config/dotnet-tools.jsoninstead.publish.yml(deleted in chore: add standard ParadeDB ORM repository scaffolding #34) withrelease.yml.Source-code sweep
A full sweep of
src/ParadeDB.EFCore/for unused public APIs / dead code turned up nothing. Every public type, factory method, enum member, translator, and internal type-mapping is referenced from tests, examples, or the DI-registered query pipeline. The library source is left untouched.Not touching
assets/paradedb-logo.png— still packed into the NuGet package as<PackageIcon>viasrc/Directory.Build.props:13. Keeps it..config/dotnet-tools.json— active (csharpier)..editorconfig,.csharpierignore— active.Test plan
Lintjob, which depends on.config/dotnet-tools.json).ParadeDB.EFCore.slnxloads, Solution folder shows the refreshed file list, no broken references.dotnet tool restoreanddotnet csharpier check .still work locally with the rootdotnet-tools.jsongone.