test: Remove redundant unit tests and create a single unified suite - #50
Merged
Conversation
isaacvando
requested review from
mdashti,
philippemnoel,
rebasedming and
stuhood
as code owners
May 22, 2026 19:49
isaacvando
force-pushed
the
consolidate-unit-tests
branch
from
May 22, 2026 19:51
a4cd48f to
6ce3551
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
- Coverage 87.25% 85.87% -1.39%
==========================================
Files 29 29
Lines 361 361
Branches 37 37
==========================================
- Hits 315 310 -5
- Misses 34 39 +5
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
Most of the unit tests cover functionality that is already tested by the integration tests (now that the integration tests include the generated SQL).
I added any missing unit tests to the main QueryTests file and remove the unit test project. This approach allows us to have more robust coverage than before with fewer total tests.
What
Why
How
Tests