feat!: rename bm25 APIs to paradedb and always use the paradedb access method - #91
Open
rebasedming wants to merge 1 commit into
Open
feat!: rename bm25 APIs to paradedb and always use the paradedb access method#91rebasedming wants to merge 1 commit into
rebasedming wants to merge 1 commit into
Conversation
rebasedming
requested review from
isaacvando,
mdashti,
philippemnoel and
stuhood
as code owners
July 27, 2026 15:37
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 91.99% 92.37% +0.38%
==========================================
Files 26 26
Lines 837 879 +42
Branches 102 105 +3
==========================================
+ Hits 770 812 +42
Misses 27 27
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
rebasedming
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements paradedb/paradedb#5706 as a breaking rename — no configurability, no fallbacks:
HasBm25Index→HasParadeDbIndex,Bm25IndexBuilder<TEntity>→ParadeDbIndexBuilder<TEntity>(old names removed)USING paradedb— noHasMethod, no method annotation, nopg_amprobing anywhereRequires pg_search 0.25.0+; released images fail at index creation as expected.
Tests
net8.0/net9.0/net10.0: 109/109 each against a pg_search 0.25.0 dev server. csharpier/api-coverage/markdownlint/codespell clean.