Skip to content

fix: restore integration test discovery and sourced bootstrap flow - #26

Merged
ankitml merged 1 commit into
mainfrom
codex/audit-critical-fixes
Mar 3, 2026
Merged

fix: restore integration test discovery and sourced bootstrap flow#26
ankitml merged 1 commit into
mainfrom
codex/audit-critical-fixes

Conversation

@philippemnoel

Copy link
Copy Markdown
Member

What

  • fix integration rspec glob pattern in rake and script runners
  • make scripts/rbenv_bootstrap.sh safe when sourced by using return semantics

Why

  • integration runs were not discovering *_integration_spec.rb files
  • sourced bootstrap path could exit parent scripts before tests executed

How

  • use a single valid integration glob: **/*_integration_spec.rb
  • add bootstrap_return helper to return when sourced and exit when executed directly

Tests

  • bash -n scripts/rbenv_bootstrap.sh scripts/run_integration_tests.sh
  • ruby -e 'puts Dir.glob("spec/**/*_integration_spec.rb").size'

@philippemnoel
philippemnoel force-pushed the codex/audit-critical-fixes branch from f15dd19 to 771038e Compare March 2, 2026 18:36
@ankitml
ankitml merged commit a0db989 into main Mar 3, 2026
13 checks passed
@ankitml
ankitml deleted the codex/audit-critical-fixes branch March 3, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants