fix: Allow aliased expressions in indexes - #79
Merged
Conversation
isaacvando
requested review from
mdashti,
philippemnoel,
rebasedming and
stuhood
as code owners
April 13, 2026 17:53
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 89.97% 89.99% +0.01%
==========================================
Files 19 19
Lines 2355 2358 +3
Branches 698 702 +4
==========================================
+ Hits 2119 2122 +3
Misses 236 236
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
isaacvando
force-pushed
the
allow-aliased-expressions-in-indexes
branch
from
April 13, 2026 18:33
696c17b to
3c53c6c
Compare
This reverts commit 314459b.
philippemnoel
approved these changes
Apr 13, 2026
philippemnoel
pushed a commit
to paradedb/paradedb
that referenced
this pull request
Apr 15, 2026
# Ticket(s) Closed - Closes # ## What Adds ORM snippets to the index creation docs. This will allow us to remove the index creation docs from the ORM READMEs. paradedb/rails-paradedb#79, paradedb/rails-paradedb#80, and paradedb/rails-paradedb#82 should be released before this is published so that all of the snippets work correctly. None of the ORMs support creating indexes with more than 32 columns. I'm not convinced we should support this in the ORMs personally as we'd have to create the type to hold the 33+ columns and manage that also. Seems like thre would be a lot of room for things to go wrong there. ## Why This centralizes the docs and will allow us to clean up the ORM READMEs. ## How ## Tests I modified the smoke test snippet job to support running these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
What
Adds support for indexed expressions with aliases like
(rating + 1)::pdb.alias('my_rating').Why
How
Tests