chore: replace no-op final-newline lint with a real check; drop irrelevant excludes - #68
Merged
Merged
Conversation
philippemnoel
requested review from
isaacvando,
mdashti,
rebasedming and
stuhood
as code owners
June 14, 2026 21:20
philippemnoel
force-pushed
the
chore/fix-final-newline-lint
branch
from
June 14, 2026 21:30
366bd18 to
aecb8fc
Compare
philippemnoel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
lint-format.ymlPrint Modified Files step rangit ls-files --modified— which lists files differing between the working tree and the index. On a fresh CI checkout nothing is modified, so it was always empty: the step passed unconditionally and never actually checked anything.Fix
git grep -Illists tracked text files; fails CI if any lacks a trailing newline).:(exclude)*.nix/*.sql/*.out/*.rs(+docker/manifests) excludes were copied from paradedb (a Rust/Postgres repo) and dont apply here — this repo has none of those types. Both checks now cover all tracked text files.Verified 0 violations for both checks on the current tree, so CI stays green.
Part of an org-wide sweep (mirrors paradedb/paradedb#5324).