chore: Critical: fix BM25 autogenerate expression normalization - #7
Merged
Conversation
philippemnoel
force-pushed
the
codex/audit-critical-fixes
branch
from
March 1, 2026 17:01
839ba1f to
840919b
Compare
philippemnoel
requested review from
ankitml,
mdashti,
rebasedming and
stuhood
as code owners
March 1, 2026 17:01
philippemnoel
force-pushed
the
codex/audit-critical-fixes
branch
from
March 1, 2026 17:08
840919b to
85aea90
Compare
philippemnoel
force-pushed
the
codex/audit-critical-fixes
branch
from
March 1, 2026 17:40
50f3d27 to
b9e068d
Compare
ankitml
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
What
pdbnamespaces while removing non-pdbrelation qualifiers outside literals.Why
How
pdbqualifier prefixes outside string literals.tests/unit/test_alembic_unit.pyto cover the relevant normalization edge cases.Tests
ruff check .python -m pytest tests/unit/test_alembic_unit.pypython -m pytest tests/unit