chore: make more things public - #49
Closed
eeeebbbbrrrr wants to merge 2 commits into
Closed
Conversation
rebasedming
previously approved these changes
Jun 11, 2025
eeeebbbbrrrr
force-pushed
the
eebbrr/item-visibility
branch
from
June 17, 2025 13:30
bf0f10b to
d3112f1
Compare
added 2 commits
June 18, 2025 08:21
In implementing custom queries that are similar to tantivy's built-in PhraseQuery and RegexPhraseQuery queries I've found a number of things that can benefit from being `pub` so they can be reused externally.
…also be highlighted
eeeebbbbrrrr
force-pushed
the
eebbrr/item-visibility
branch
from
June 18, 2025 12:21
d3112f1 to
b1d721f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In implementing custom queries that are similar to tantivy's built-in PhraseQuery and RegexPhraseQuery queries I've found a number of things that can benefit from being
pubso they can be reused externally.