feat: implemented filter aggregation - #67
Merged
Merged
Conversation
…r` + Added tests
Member
|
Would it make sense for us to get feedback from upstream Tantivy team for this? |
stuhood
reviewed
Oct 3, 2025
Collaborator
Author
@philippemnoel Here's the upstream PR: quickwit-oss#2711 |
mdashti
commented
Oct 3, 2025
stuhood
approved these changes
Oct 6, 2025
stuhood
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, thanks!
Please wait to land until the consumer PR is almost ready.
mdashti
added a commit
that referenced
this pull request
Oct 21, 2025
mdashti
added a commit
that referenced
this pull request
Oct 22, 2025
mdashti
added a commit
that referenced
this pull request
Oct 22, 2025
mdashti
added a commit
that referenced
this pull request
Dec 3, 2025
mdashti
added a commit
that referenced
this pull request
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
What
Implements filter aggregation support in Tantivy, enabling multiple filtered aggregations in a single query.
Why
Currently, there's no way to compute aggregations on different filtered subsets of documents in a single query. Users must run separate queries for each filter, which is slow and inefficient. For example, computing "average price overall + average price for t-shirts + count of electronics" requires three separate queries.
Elasticsearch's filter aggregation solves this by creating a single bucket containing documents matching a query, with support for nested sub-aggregations. This is a common analytics pattern that Tantivy now supports!
How
Added a new
FilterAggregationbucket aggregation type that:QueryParser) and directQueryobjects for custom query typesDocumentQueryEvaluatorto evaluate filter queries per-document during aggregation collection, avoiding separate query executionsSegmentReaderreferences, enabling filter aggregations to create query weights and scorers per segmentSome Implementation Details:
FilterAggregationsupports two modes:FilterQuery::QueryString: Parsed using Tantivy's standardQueryParserFilterQuery::Direct: AcceptsBox<dyn Query>for custom query extensionsFilterSegmentCollectorevaluates the filter query on each document collected by the main querydoc_countand flattened sub-aggregation resultsTests
Test suite with 20 tests covering:
All tests use the
assert_agg_results!macro for clean, consistent result validation with floating-point tolerance.