feat(harness): add Hermes ACP adapter#1030
Draft
Osraka wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #109
Summary
harness-serveradapter that startshermes-acp, performs the ACP initialize/session handshake, reuses the native Hermes session id across turns, and normalizes ACPsession/updateevents into Centaur canonical events.hermesthroughHarnessKind,HarnessType, API/runtime sandbox command selection, the session CLI, integration wire-value coverage, and OpenRouter proxy fragment selection.hermes-agent[acp]==0.17.0in the sandbox image and preserves~/.hermesunder persistent sandbox state.sandbox.harnessEngine=hermes,OPENROUTER_API_KEY, andHERMES_MODEL.Context
This ports the earlier Hermes wrapper work from #142/#188 into the current Rust
harness-server/api-rspath. #142 was closed with the suggestion to translate Hermes traces into Codex App Server format and port the work to the newer API/runtime layer.Tests
cargo test --offline --manifest-path crates/harness-server/Cargo.toml hermes -- --nocapturecargo test --offline --manifest-path services/api-rs/Cargo.toml -p centaur-session-core harness_type -- --nocapturecargo test --offline --manifest-path services/api-rs/Cargo.toml -p centaur-session-runtime codex_workload_pins_harness_via_container_args -- --nocapturecargo check --offline --manifest-path services/api-rs/Cargo.toml -p centaur-session-cli -p centaur-api-server -p centaur-api-integration-testgit diff --checkNotes
I kept this as a draft because I could not run a full sandbox/Kubernetes Hermes E2E in this environment. The adapter follows Hermes 0.17 ACP distribution (
hermes-agent[acp]/hermes-acp) and defaults provider routing to the existing OpenRouter fragment.