fix(chart): avoid duplicate agent-sandbox archive entries#1122
Open
alphastorm wants to merge 2 commits into
Open
fix(chart): avoid duplicate agent-sandbox archive entries#1122alphastorm wants to merge 2 commits into
alphastorm wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-sandboxdependency;Problem
The
centaur-0.1.105release assetcentaur-0.1.105.tgz(SHA-256fd810b08a2d13811bfed25e1a3832f57da5dd6312747785773aedb566c9f69da) contains 17 paths undercentaur/charts/agent-sandbox/twice. Every pair inspected is identical in bytes, mode, and size.Duplicate archive member names make the chart non-canonical, can cause strict archive or supply-chain verification to reject it, and create extractor-order semantics in the general case. No divergent duplicate content, installation compromise, or malicious ambiguity was observed in this artifact.
Duplicated paths
charts/agent-sandbox/Chart.yamlcharts/agent-sandbox/values.yamlcharts/agent-sandbox/templates/_controller-args.tplcharts/agent-sandbox/templates/_helpers.tplcharts/agent-sandbox/templates/clusterrolebinding-extensions.yamlcharts/agent-sandbox/templates/clusterrolebinding.yamlcharts/agent-sandbox/templates/deployment.yamlcharts/agent-sandbox/templates/extensions-rbac.generated.yamlcharts/agent-sandbox/templates/namespace.yamlcharts/agent-sandbox/templates/rbac.generated.yamlcharts/agent-sandbox/templates/service.yamlcharts/agent-sandbox/templates/serviceaccount.yamlcharts/agent-sandbox/README.mdcharts/agent-sandbox/crds/agents.x-k8s.io_sandboxes.yamlcharts/agent-sandbox/crds/extensions.agents.x-k8s.io_sandboxclaims.yamlcharts/agent-sandbox/crds/extensions.agents.x-k8s.io_sandboxtemplates.yamlcharts/agent-sandbox/crds/extensions.agents.x-k8s.io_sandboxwarmpools.yamlThe source-correlated cause is the release sequence:
helm dependency build contrib/chartpackages the localfile://charts/agent-sandboxdependency as a.tgzwhile the checked-incharts/agent-sandbox/directory remains present.centaur/charts/<chart-name>/; both representations are namedagent-sandbox, so their files receive the same tar member paths.Fix
The workflow now:
agent-sandbox-*.tgzexists;charts/agent-sandbox/copy from staging;skip_packaging: true.The checked-in dependency source remains available for development and linting; only the temporary release staging copy is normalized.
Verification
fd810b08a2d13811bfed25e1a3832f57da5dd6312747785773aedb566c9f69daand reproduces exactly 17 identical duplicate pairs.python3 .github/scripts/check-chart-archive.py /tmp/centaur-0.1.105.tgz: exits non-zero and lists exactly 17 duplicate paths.helm dependency build contrib/charthelm lint contrib/chartand lint of the corrected packaged archivehelm packagecommand from the workflowpython3 .github/scripts/check-chart-archive.py .cr-release-packages/centaur-*.tgz: passes on the corrected package.git diff --checkNo Kubernetes deployment is needed for this release-packaging-only change.