Skip to content

fix: match sandbox tool allowlist by project name#989

Open
erayack wants to merge 1 commit into
paradigmxyz:mainfrom
erayack:fix/sandbox-tool-allowlist-project-name
Open

fix: match sandbox tool allowlist by project name#989
erayack wants to merge 1 commit into
paradigmxyz:mainfrom
erayack:fix/sandbox-tool-allowlist-project-name

Conversation

@erayack

@erayack erayack commented Jul 9, 2026

Copy link
Copy Markdown

1. What & Why

  • Fixes an overlay-tool availability bug where allowlisted tools could be discarded before sandbox script discovery if their package directory differed from [project].name.
  • Uses the same naming boundary already trusted by script discovery rather than introducing a second allowlist convention or requiring tool metadata churn.

2. High-Level Impact & Architecture

  • Keeps the sandbox tool pipeline consistent across the copy and discovery phases: allow/block decisions now understand both filesystem identity and Python project identity.
  • Preserves existing overlay conflict behavior by keeping duplicate detection directory-based; this avoids changing source precedence semantics.
  • Degrades safely on malformed tool metadata by warning and falling back to directory-name matching.

3. Reviewer Checklist / Risk Areas

  • Verify copy-time filtering remains backward compatible for unset allowlists, directory-name allowlists, and directory-name blocklists.
  • Review malformed pyproject.toml handling to ensure startup remains resilient without hiding diagnosable metadata problems.
  • No public API, chart, schema, or tool metadata changes are intended.

Validation:

  • python3 -m unittest services/sandbox/test_install_tool_shims.py
  • uvx ruff check services/sandbox/install_tool_shims.py services/sandbox/test_install_tool_shims.py

@erayack
erayack force-pushed the fix/sandbox-tool-allowlist-project-name branch from 616b8a3 to 3a5a2fb Compare July 9, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant