fix(sort): skip excluded columns when sorting DataFrame#253
Open
AuburyEssentian wants to merge 1 commit intoparadigmxyz:mainfrom
Open
fix(sort): skip excluded columns when sorting DataFrame#253AuburyEssentian wants to merge 1 commit intoparadigmxyz:mainfrom
AuburyEssentian wants to merge 1 commit intoparadigmxyz:mainfrom
Conversation
When a column listed in default_sort() has been excluded via
exclude_columns, it is absent from the output DataFrame. Polars
then returns an error ('not found: <col>') which propagates as a
chunk failure and produces zero rows in the output.
Fix: filter sort_columns to only those present in the DataFrame
schema before calling df.sort(). If no sort columns remain after
filtering, return the DataFrame unsorted rather than erroring.
Fixes paradigmxyz#221
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #221.
When a column listed in a dataset's
default_sort()is excluded viaexclude_columns, it is absent from the outputDataFrame. Polars then returns an error (not found: <col>) which propagates as a chunk failure and produces zero rows in the output — even though the data was collected correctly.The Contracts dataset is the canonical reproducer:
default_sort()returns["block_number", "create_index"], so excludingcreate_indexsilently drops all results.Fix
In
sort_by_schema, filtersort_columnsdown to only those columns that exist in the DataFrame schema before callingdf.sort(). If none remain, return the DataFrame unsorted rather than erroring.This is a one-line conceptual fix confined to
crates/freeze/src/types/dataframes/sort.rsand applies to any dataset that lists a column indefault_sort()that can be excluded.Testing
cargo build -p cryo_freezepasses cleanly.cryo contracts --exclude create_indexwould return 0 rows with chunk errors; after, it returns results sorted byblock_numberonly.