Skip to content

fix: widen trace gas fields from u32 to u64 to prevent overflow #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dylantirandaz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: widen trace gas fields from u32 to u64 to prevent overflow #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions crates/freeze/src/datasets/trace_calls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ pub struct TraceCalls {
action_from: Vec<Option<Vec<u8>>>,
action_to: Vec<Option<Vec<u8>>>,
action_value: Vec<String>,
action_gas: Vec<Option<u32>>,
action_gas: Vec<Option<u64>>,
action_input: Vec<Option<Vec<u8>>>,
action_call_type: Vec<Option<String>>,
action_init: Vec<Option<Vec<u8>>>,
action_reward_type: Vec<Option<String>>,
action_type: Vec<String>,
result_gas_used: Vec<Option<u32>>,
result_gas_used: Vec<Option<u64>>,
result_output: Vec<Option<Vec<u8>>>,
result_code: Vec<Option<Vec<u8>>>,
result_address: Vec<Option<Vec<u8>>>,
Expand Down Expand Up @@ -106,7 +106,7 @@ fn process_action(action: &Action, columns: &mut TraceCalls, schema: &Table) {
store!(schema, columns, action_from, Some(action.from.to_vec()));
store!(schema, columns, action_to, Some(action.to.to_vec()));
store!(schema, columns, action_value, action.value.to_string());
store!(schema, columns, action_gas, Some(action.gas as u32));
store!(schema, columns, action_gas, Some(action.gas as u64));
store!(schema, columns, action_input, Some(action.input.to_vec()));
store!(
schema,
Expand All @@ -121,7 +121,7 @@ fn process_action(action: &Action, columns: &mut TraceCalls, schema: &Table) {
store!(schema, columns, action_from, Some(action.from.to_vec()));
store!(schema, columns, action_to, None);
store!(schema, columns, action_value, action.value.to_string());
store!(schema, columns, action_gas, Some(action.gas as u32));
store!(schema, columns, action_gas, Some(action.gas as u64));
store!(schema, columns, action_input, None);
store!(schema, columns, action_call_type, None);
store!(schema, columns, action_init, Some(action.init.to_vec()));
Expand Down Expand Up @@ -158,13 +158,13 @@ fn process_action(action: &Action, columns: &mut TraceCalls, schema: &Table) {
fn process_result(result: &Option<TraceOutput>, columns: &mut TraceCalls, schema: &Table) {
match result {
Some(TraceOutput::Call(result)) => {
store!(schema, columns, result_gas_used, Some(result.gas_used as u32));
store!(schema, columns, result_gas_used, Some(result.gas_used as u64));
store!(schema, columns, result_output, Some(result.output.to_vec()));
store!(schema, columns, result_code, None);
store!(schema, columns, result_address, None);
}
Some(TraceOutput::Create(result)) => {
store!(schema, columns, result_gas_used, Some(result.gas_used as u32));
store!(schema, columns, result_gas_used, Some(result.gas_used as u64));
store!(schema, columns, result_output, None);
store!(schema, columns, result_code, Some(result.code.to_vec()));
store!(schema, columns, result_address, Some(result.address.to_vec()));
Expand Down
12 changes: 6 additions & 6 deletions crates/freeze/src/datasets/traces.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ pub struct Traces {
action_from: Vec<Option<Vec<u8>>>,
action_to: Vec<Option<Vec<u8>>>,
action_value: Vec<String>,
action_gas: Vec<Option<u32>>,
action_gas: Vec<Option<u64>>,
action_input: Vec<Option<Vec<u8>>>,
action_call_type: Vec<Option<String>>,
action_init: Vec<Option<Vec<u8>>>,
action_reward_type: Vec<Option<String>>,
action_type: Vec<String>,
result_gas_used: Vec<Option<u32>>,
result_gas_used: Vec<Option<u64>>,
result_output: Vec<Option<Vec<u8>>>,
result_code: Vec<Option<Vec<u8>>>,
result_address: Vec<Option<Vec<u8>>>,
Expand Down Expand Up @@ -152,7 +152,7 @@ fn process_action(action: &Action, columns: &mut Traces, schema: &Table) {
store!(schema, columns, action_from, Some(action.from.to_vec()));
store!(schema, columns, action_to, Some(action.to.to_vec()));
store!(schema, columns, action_value, action.value.to_string());
store!(schema, columns, action_gas, Some(action.gas as u32));
store!(schema, columns, action_gas, Some(action.gas as u64));
store!(schema, columns, action_input, Some(action.input.to_vec()));
store!(
schema,
Expand All @@ -167,7 +167,7 @@ fn process_action(action: &Action, columns: &mut Traces, schema: &Table) {
store!(schema, columns, action_from, Some(action.from.to_vec()));
store!(schema, columns, action_to, None);
store!(schema, columns, action_value, action.value.to_string());
store!(schema, columns, action_gas, Some(action.gas as u32));
store!(schema, columns, action_gas, Some(action.gas as u64));
store!(schema, columns, action_input, None);
store!(schema, columns, action_call_type, None);
store!(schema, columns, action_init, Some(action.init.to_vec()));
Expand Down Expand Up @@ -204,13 +204,13 @@ fn process_action(action: &Action, columns: &mut Traces, schema: &Table) {
fn process_result(result: &Option<TraceOutput>, columns: &mut Traces, schema: &Table) {
match result {
Some(TraceOutput::Call(result)) => {
store!(schema, columns, result_gas_used, Some(result.gas_used as u32));
store!(schema, columns, result_gas_used, Some(result.gas_used as u64));
store!(schema, columns, result_output, Some(result.output.to_vec()));
store!(schema, columns, result_code, None);
store!(schema, columns, result_address, None);
}
Some(TraceOutput::Create(result)) => {
store!(schema, columns, result_gas_used, Some(result.gas_used as u32));
store!(schema, columns, result_gas_used, Some(result.gas_used as u64));
store!(schema, columns, result_output, None);
store!(schema, columns, result_code, Some(result.code.to_vec()));
store!(schema, columns, result_address, Some(result.address.to_vec()));
Expand Down